search

ubports / ubuntu-ui-toolkit

Moved to https://gitlab.com/ubports/core/lomiri-ui-toolkit
https://gitlab.com/ubports/core/lomiri-ui-toolkit
GNU Lesser General Public License v3.0
13 stars 21 forks source link

g++ 5.4.0 is NOT enough #37

Closed antoniosap closed 5 years ago

antoniosap commented 5 years ago

please add min compiler requirements. thanks.

dobey commented 5 years ago

Please explain the bug report better. ubuntu-ui-toolkit builds just fine with gcc 5.3.1, which is the version in Ubuntu 16.04, as well as 7.3.0 that is in 18.04.

antoniosap commented 5 years ago 
/home/antonio/workspace-qt/repo/ubuntu-ui-toolkit/src/UbuntuMetrics/applicationmonitor.cpp:153: error: ‘new’ of type ‘UMApplicationMonitorPrivate’ with extended alignment 64 [-Werror=aligned-new=]
     : d_ptr(new UMApplicationMonitorPrivate(this))
                                                 ^

Last Qt version 5.12 / 5.13

antoniosap commented 5 years ago 

/home/antonio/workspace-qt/repo/ubuntu-ui-toolkit/src/UbuntuMetrics/applicationmonitor.cpp: In constructor ‘UMApplicationMonitor::UMApplicationMonitor()’:
/home/antonio/workspace-qt/repo/ubuntu-ui-toolkit/src/UbuntuMetrics/applicationmonitor.cpp:153:49: error: ‘new’ of type ‘UMApplicationMonitorPrivate’ with extended alignment 64 [-Werror=aligned-new=]
     : d_ptr(new UMApplicationMonitorPrivate(this))
                                                 ^
/home/antonio/workspace-qt/repo/ubuntu-ui-toolkit/src/UbuntuMetrics/applicationmonitor.cpp:153:49: note: uses ‘void* operator new(std::size_t)’, which does not have an alignment parameter
/home/antonio/workspace-qt/repo/ubuntu-ui-toolkit/src/UbuntuMetrics/applicationmonitor.cpp:153:49: note: use ‘-faligned-new’ to enable C++17 over-aligned new support
/home/antonio/workspace-qt/repo/ubuntu-ui-toolkit/src/UbuntuMetrics/applicationmonitor.cpp: In member function ‘void UMApplicationMonitorPrivate::startMonitoring(QQuickWindow*)’:
/home/antonio/workspace-qt/repo/ubuntu-ui-toolkit/src/UbuntuMetrics/applicationmonitor.cpp:272:86: error: ‘new’ of type ‘WindowMonitor’ with extended alignment 64 [-Werror=aligned-new=]
             new WindowMonitor(q_func(), window, m_loggingThread->ref(), m_flags, ++id);
                                                                                      ^
/home/antonio/workspace-qt/repo/ubuntu-ui-toolkit/src/UbuntuMetrics/applicationmonitor.cpp:272:86: note: uses ‘void* operator new(std::size_t)’, which does not have an alignment parameter
/home/antonio/workspace-qt/repo/ubuntu-ui-toolkit/src/UbuntuMetrics/applicationmonitor.cpp:272:86: note: use ‘-faligned-new’ to enable C++17 over-aligned new support
cc1plus: all warnings being treated as errors
Makefile:2201: recipe for target '.obj/applicationmonitor.o' failed
make[2]: *** [.obj/applicationmonitor.o] Error 1
make[2]: *** Waiting for unfinished jobs....```
dobey commented 5 years ago

What branch are you building?

Newer versions of Qt are not yet supported. We ship Qt 5.9 in Ubuntu Touch. Also, the code is not C++17 compliant, so trying to compile with that standard will not work.

antoniosap commented 5 years ago

Qt 5.13.0

dobey commented 5 years ago

Qt 5.13.0

There is no such branch in this repository.