search

ubports / ubuntu-ui-toolkit

Moved to https://gitlab.com/ubports/core/lomiri-ui-toolkit
https://gitlab.com/ubports/core/lomiri-ui-toolkit
GNU Lesser General Public License v3.0
13 stars 21 forks source link

Use a Ash Grey for Default Button Color #42

Closed cibersheep closed 5 years ago

cibersheep commented 5 years ago

Default grey used before was not in the palette. Fixes #41

mardy commented 5 years ago

I would rather add the existing color to the palette; I feel that a lighter grey looks much better.

cibersheep commented 5 years ago

I understand but #b2b2b2 is not used in any other place than in the default button color. It feels more like a mistake or a left over

dobey commented 5 years ago

I understand but #b2b2b2 is not used in any other place than in the default button color. It feels more like a mistake or a left over

It's also used in version 1.2 fo the Ambiance style, in two places:

ubuntu-ui-toolkit/src/imports/Components/Themes/Ambiance/1.2/ComboButtonStyle.qml:        defaultColor: "#b2b2b2"
ubuntu-ui-toolkit/src/imports/Components/Themes/Ambiance/1.2/ButtonStyle.qml:    property color defaultColor: "#b2b2b2"
cibersheep commented 5 years ago

ubuntu-ui-toolkit/src/imports/Components/Themes/Ambiance/1.2/ComboButtonStyle.qml: defaultColor: "#b2b2b2"

Which was updated on 1.3 to foreground. #b2b2b2 is a left over from old style https://github.com/ubports/ubuntu-ui-toolkit/blob/xenial/src/imports/Components/Themes/Ambiance/1.3/ComboButtonStyle.qml#L48

dobey commented 5 years ago

@cibersheep Sure, but if we're changing the color (btw, it says in the comment you removed it should be added to the palette), why shouldn't we also adjust it in the 1.2 style, for the case where apps are still using the older imports?

cibersheep commented 5 years ago

@cibersheep Sure, but if we're changing the color (btw, it says in the comment you removed it should be added to the palette), why shouldn't we also adjust it in the 1.2 style, for the case where apps are still using the older imports?

Interesting. I would say that we leave 1.2 as it is as is superseded by 1.3 (which if I remember correctly, has other color tweaks as the blue for focus instead of green).