Closed cibersheep closed 4 years ago
When changing API in UITK, you will additionally need to add the new expected API to the tests. This prevents accidentally adding, removing, or changing API.
Compare the output of the tests (https://ci.ubports.com/blue/organizations/jenkins/ubuntu-ui-toolkit/detail/PR-54/1/pipeline#step-34-log-2216) with the file components.api
to fix the problem.
Oh, I see. Thanks, I'll try to fix that
Compare the output of the tests (https://ci.ubports.com/blue/organizations/jenkins/ubuntu-ui-toolkit/detail/PR-54/1/pipeline#step-34-log-2216) with the file
components.api
to fix the problem.
I have added the new lightBlue
to the components.api
. I hope that fixes it.
Weeeeeee
Before:
After:
Holding off a day on this merge has been requested as we check more apps for design changes
I have gone through the system and, as you pointed, OpenStore and Clock apps have an issue with current selected tabs. I have not found more apps, as header sections are ok, therefore I say: let's stick with Section style (focus vs tertiaryText) with the new blue.
I've sent a MR to the OpenStore to fix this now and should be ok when merged.
Today I'll MR the clock app and with that, the theme should be ok.
We have to check SuruDark use of blue, now we use UbuntuColor.blue
and should be changed to corresponding theme values (ie: theme.palette.selected.focus
, etc).
Dialer:
Clock:
More screensheeps
Apply system upgrades:
Install stable version of an app:
We found some core apps using blue for less-than-ideal purposes, these have now been fixed (or there are PRs in for them).
White text on blue has little contrast so I:
Ambiance blue:
SuruDark:
Before:
After: