ubports / ubuntu-ui-toolkit

Moved to https://gitlab.com/ubports/core/lomiri-ui-toolkit
https://gitlab.com/ubports/core/lomiri-ui-toolkit
GNU Lesser General Public License v3.0
13 stars 21 forks source link

Blue, Green and Read Color Tweaks #54

Closed cibersheep closed 4 years ago

cibersheep commented 4 years ago

White text on blue has little contrast so I:

Ambiance blue:

imatge

SuruDark:

Before: imatge

After: imatge

UniversalSuperBox commented 4 years ago

When changing API in UITK, you will additionally need to add the new expected API to the tests. This prevents accidentally adding, removing, or changing API.

Compare the output of the tests (https://ci.ubports.com/blue/organizations/jenkins/ubuntu-ui-toolkit/detail/PR-54/1/pipeline#step-34-log-2216) with the file components.api to fix the problem.

cibersheep commented 4 years ago

Oh, I see. Thanks, I'll try to fix that

cibersheep commented 4 years ago

Compare the output of the tests (https://ci.ubports.com/blue/organizations/jenkins/ubuntu-ui-toolkit/detail/PR-54/1/pipeline#step-34-log-2216) with the file components.api to fix the problem.

I have added the new lightBlue to the components.api. I hope that fixes it.

cibersheep commented 4 years ago

imatge

Weeeeeee

cibersheep commented 4 years ago

Before:

imatge

After:

imatge

UniversalSuperBox commented 4 years ago

Holding off a day on this merge has been requested as we check more apps for design changes

cibersheep commented 4 years ago

I have gone through the system and, as you pointed, OpenStore and Clock apps have an issue with current selected tabs. I have not found more apps, as header sections are ok, therefore I say: let's stick with Section style (focus vs tertiaryText) with the new blue.

I've sent a MR to the OpenStore to fix this now and should be ok when merged.

Today I'll MR the clock app and with that, the theme should be ok.

We have to check SuruDark use of blue, now we use UbuntuColor.blue and should be changed to corresponding theme values (ie: theme.palette.selected.focus, etc).

Dialer: imatge

Clock: imatge

cibersheep commented 4 years ago

More screensheeps

Apply system upgrades:

imatge

Install stable version of an app: imatge

UniversalSuperBox commented 4 years ago

We found some core apps using blue for less-than-ideal purposes, these have now been fixed (or there are PRs in for them).