ubports / ubuntu-ui-toolkit

Moved to https://gitlab.com/ubports/core/lomiri-ui-toolkit
https://gitlab.com/ubports/core/lomiri-ui-toolkit
GNU Lesser General Public License v3.0
13 stars 21 forks source link

Don't assume that a list from QML is a QList or anything #94

Closed peat-psuwit closed 4 years ago

peat-psuwit commented 4 years ago

Qt can change this internal detail at any time, and they've done so in 5.12.8 & 5.15.0. Instead, use QQmlListReference, which is a documented way of accessing a QML list.

mariogrip commented 4 years ago

Seems like @z3ntu worked on the same issue https://github.com/ubports/ubuntu-ui-toolkit/pull/83/commits/2411c73d2201804b22cf59f84607219a08236870

z3ntu commented 4 years ago

iirc I reverted my change because the tests were failing on CI (Qt 5.9?) - but on Qt 5.14/15 the component worked fine