ubports / unity8

The operating environment for everywhere. Lomiri development has moved to https://gitlab.com/ubports/development/core/lomiri
https://lomiri.com/
GNU General Public License v3.0
722 stars 99 forks source link

Re-introduce interactive drawer blur #421

Closed fredldotme closed 2 years ago

fredldotme commented 2 years ago

Allow to set a new 'interactiveBlur' based on a new Android property, called 'ubuntu.unity8.interactive_blur'.

This should be used to indicate the ability to draw interactive blur in the drawer quickly without causing too many dropped frames.

On device ports which set the necessary getprop property, allow the use of interactive blur in the drawer. Use static blur otherwise.

c4pp4 commented 2 years ago

RC OTA22: 2022-W04 (devices: Mi A2 and Xperia X) Not sure If I'm testing it right or I have the right devices. I've done 'setprop ubuntu.unity8.interactive_blur true' and 'restart unity8'. After that when the app drawer is appearing, animation is very choppy.

fredldotme commented 2 years ago

RC OTA22: 2022-W04 (devices: Mi A2 and Xperia X) Not sure If I'm testing it right or I have the right devices. I've done 'setprop ubuntu.unity8.interactive_blur true' and 'restart unity8'. After that when the app drawer is appearing, animation is very choppy.

Yes, this is exactly the reason the porter has to opt-in on the feature instead of the user. If the porter determines it's not fluid enough then better not enable it. Works fine on Pixel 3a though.

Flohack74 commented 2 years ago

We might be able to speed it up with better QML later, but for now its truly device-specific ;)