search

ubports / unity8

The operating environment for everywhere. Lomiri development has moved to https://gitlab.com/ubports/development/core/lomiri
https://lomiri.com/
GNU General Public License v3.0
722 stars 99 forks source link

YUMI-14 Notifications: allow more than 2 lines when hint "x-canonical-truncation" is set to false #441

Closed lduboeuf closed 1 year ago

lduboeuf commented 2 years ago

Actual Notification implementation only allows 2 lines per popup. the idea is to use the existing hint "x-canonical-truncation" to allow more than 2 lines and still limit to 20 lines. screenshot20220707_140413521

cibersheep commented 2 years ago

Do you have a screenshot of the change :)?

lduboeuf commented 2 years ago

screenshot20220617_200331934

^ maximum of 12 lines ( like snap decision notification )

cibersheep commented 2 years ago

Thank you :)

Is that as expanded state?

The text on the bubble looks a bit messy (is that a mock up?)

lduboeuf commented 2 years ago

The text on the bubble looks a bit messy (is that a mock up?)

no, real test. But i've made some random sentences, probably with spaces and line breaks

cibersheep commented 2 years ago

no, real test. But i've made some random sentences, probably with spaces and line breaks

Ah, I see :)

I feel it too big (I guess I'm not used to them being that long) but if you need them to be....

More questions: How does those changes affect to other bubbles? Like audio volume warning when plugin headphones?

lduboeuf commented 2 years ago

no, real test. But i've made some random sentences, probably with spaces and line breaks

Ah, I see :)

I feel it too big (I guess I'm not used to them being that long) but if you need them to be....

Oh i know why, it is because i've played with font size, but i don't pushed them in this PR

More questions: How does those changes affect to other bubbles? Like audio volume warning when plugin headphones?

Behaves like before,

cibersheep commented 2 years ago

Oh i know why, it is because i've played with font size, but i don't pushed them in this PR

Aaah... hi hi hi... sorry, it's my obsession (you might already know that)

More questions: How does those changes affect to other bubbles? Like audio volume warning when plugin headphones?

Behaves like before,

Ok, that's nice. Thanks :*

lduboeuf commented 2 years ago

@cibersheep i've updated the example of the notification with current font size ( see at the top )

gber commented 2 years ago

Please add support for x-lomiri-truncation, x-canonical-truncation is deprecated in the main branch.

Flohack74 commented 1 year ago

CI is read on that PR, any particular reason?