search

ubports / unity8

The operating environment for everywhere. Lomiri development has moved to https://gitlab.com/ubports/development/core/lomiri
https://lomiri.com/
GNU General Public License v3.0
726 stars 99 forks source link

Notch support #442

Open ilyakooo0 opened 2 years ago

ilyakooo0 commented 2 years ago

This is a rebased version of #403

I don't really understand what is going on, I just rebased the PR (:

Flohack74 commented 2 years ago

Nice, we need to clean it a bit, but I definitely want this for 2 distinct phone models now ;)

JamiKettunen commented 2 years ago

@Flohack74 Is this "confirmed" to be the way we want to go forward with notch integration on Unity 8 / Lomiri shell? I wouldn't mind making a parallel MR for focal on https://gitlab.com/ubports/development/core/lomiri myself ^^

JamiKettunen commented 2 years ago

With 20.04 (and future) in mind we should refactor plugins/Utils/deviceconfigparser.* changes and get a libdeviceinfo replacement as that is also available on 16.04 already while the deviceconfigparser is gone in focal Ignore me, while libdeviceinfo is also on 16.04 we probably don't want to start integrating it into the shell if it already wasn't before, so this might just have to be done differently on 20.04 and it doesn't seem there's backwards compatability for the old deviceconfigparser way so with migration to focal existing configuration from xenial will have to be migrated to deviceinfo.