qml: Further simplify BackgroundBlur

ubports / unity8

The operating environment for everywhere. Lomiri development has moved to https://gitlab.com/ubports/development/core/lomiri

https://lomiri.com/

GNU General Public License v3.0

722 stars 99 forks source link

qml: Further simplify BackgroundBlur #451

Closed fredldotme closed 2 years ago

fredldotme commented 2 years ago

Remove unnecessary ShaderEffect
Bind redrawing to the 'visible' property
Use same blur radius as the camera-app
Fixes shell-induced micro-jumps in apps

fredldotme commented 2 years ago

Tested on the Pixel 3a. A similarly-specced device would be optimal for testing this. To test before and after results each:

Open https://vsynctester.com in Morph
Keep Drawer closed
Inspect potential jumps in drawing the sliding image inside the website's canvas

Danfro commented 1 year ago

The website mentioned above seems to work fine on my Xperia X. Although the lines drawn do go through the bottom and top end of the drawing area. Is that bad? But the image is scrolling smoothly with 15 to 23 fps.

grafik

ilyakooo0 commented 1 year ago

Not sure how the website is related to blur, but this is the results on a Pixel 3a

https://user-images.githubusercontent.com/6209627/202761065-96b73028-c01c-4399-911d-1b1a8e7b3fc4.mov