keyrxng2
commented
1 month ago I think it's best if we follow this approach with things
-
Scope Clarification:
- Instead of a generic utility package, let's focus on a specific area. For example, we could create a package specifically for handling date-related functions (
@my-awesome-utils/dates). - This narrower scope will allow us to provide more specialized and well-tested functions.
- Instead of a generic utility package, let's focus on a specific area. For example, we could create a package specifically for handling date-related functions (
-
Function Naming Convention:
- I recommend using a consistent naming convention for our utility functions. We can follow the pattern of
moduleName.functionName. - For instance:
dates.formatDate(date: Date, format: string): stringdates.calculateAge(birthDate: Date): number
- I recommend using a consistent naming convention for our utility functions. We can follow the pattern of
Keyrxng
github-actions[bot]
We need to create an npm package that provides a set of utility functions written in TypeScript. These functions will be useful for common tasks across our projects. The package should be well-tested, documented, and maintainable.
stringUtils.capitalize(str: string): stringarrayUtils.shuffle<T>(arr: T[]): T[]dateUtils.formatDate(date: Date, format: string): stringmathUtils.calculateDiscount(originalPrice: number, discountPercentage: number): numberAcceptance Criteria
@my-awesome-utils/core.Scope Clarification:
@my-awesome-utils/dates).Function Naming Convention:
moduleName.functionName.dates.formatDate(date: Date, format: string): stringdates.calculateAge(birthDate: Date): numberIt seems that the author of the issue agrees with this approach. However, there is a comment that says "/rewrite" which suggests that the issue may need to be rewritten. It is unclear what exactly needs to be rewritten, so further clarification may be needed.
No linked issues or pull requests were found in the conversation.
Based on the information provided, it is recommended to update the issue spec to include the scope clarification and function naming convention. If there is a need to rewrite the issue, it should be discussed further to determine the specific changes required.