search

ubsicap / paratext_demo_plugins

Sample code to demonstrate how to create a Paratext plugin
2 stars 4 forks source link

The QuoteAnnotationPlugin (demo) causes text not to wrap #12

Closed tombogle closed 2 years ago

tombogle commented 2 years ago

I haven't yet figured out if this is a problem in the demo plugin or in Paratext itself, but I'm guessing the latter, since it doesn't seem like a plugin that is just trying to apply annotations could/should cause Paratext to lay out the data differently beyond what is needed to apply the highlighting.

FoolRunning commented 2 years ago

Can you give a screenshot of what you are seeing? I wasn't able to reproduce what I think you are describing.

tombogle commented 2 years ago

Without annotations (note: no horizontal scroll bar) image

With annotations: image

tombogle commented 2 years ago

Plugin is generating bazillions of zero-width annotations, and (due to a seemingly unfixable deficiency in Paratext/Firefox) wrapping is suppressed between annotation spans. As a separate improvement to Paratext itself, if a plugin generates zero-width annotations with no icon, Paratext will supply an error icon and tool tip text to indicate that the annotation is invalid.

tombogle commented 2 years ago

Fixed by https://github.com/ubsicap/paratext_demo_plugins/pull/13