Closed ericpyle closed 6 months ago
Overall, I made the following changes which can be seen with the comparison of these commits: https://github.com/ubsicap/sltt-app/compare/e0f9fe77be9c3e9a856fef2831c9075c6319977c...078a5d809dbfc2675ef23014e2159594537be135
productName
(and repo) to sltt-appappId
to net.sltt-bible.app
ffmpeg-static
and ffprobe-static
based on app.asar.unpacked
(hope this works on macOS as well)out/client
build
configurationmain/index.ts
:
autoUpdater
loadUrlOrFile
to load files from disk, and pass any options (e.g. code
from auth0 callback)webRequest.onBeforeRequest({ urls: ['http://localhost/callback*']
to call loadUrlOrFile()
when it receives a callback to http://localhost/callback
with query parameters from auth0
in the sltt clientAllison, To test auto-updater:
To test offline:
@ericpyle @deafjava Please review my testing steps and let me know if they are adequate to pass this to Done....
Testing Steps:
@ericpyle @deafjava Please review my testing steps and let me know if they are adequate to pass this to Done....
- Disconnected from the internet AS EXPECTED, I can still navigate through the PORTIONS. THERE is no browser (this is a desktop client/app) so I cannot hit "Refresh" on the browser.
Good point: revised steps:
To test offline:
@weagale wrote "UNEXPECTEDLY, errors began to happen and at first the desktop icon would not work immediately."
I'm not sure what you mean by "errors began to happen". Maybe a screen/video capture would be helpful.
@ericpyle IT seems the errors only happened on the version 2.44.1 and are not repeatable in version 2.46.4. So I think that's ok. I backed up to version 2.44.1 to repeat it:
Working on a video compressed enough to load.
The video was too long to upload but here was the error and it only happended for t he earlier version which Caio implies is fine.
Unless @ericpyle objects, I think tests should be conducted always on newer versions
Marking Done because it all passes for the later version...
Marking Done because it all passes for the later version...
This error should no longer happen after my fix for https://github.com/ubsicap/sltt-app/issues/2
Unless @ericpyle objects, I think tests should be conducted always on newer versions
I agree in general, however, the testing steps for this, did involve an older version so she could test the auto-update to new version worked. Fortunately, I think the latest version should not have this issue since we're only launching one version of the compressor. It does remind me however, that existing users who have a separate installed compressor may try to run that compressor alongside the sltt-app, in which case we'll encounter this error again. So, I should probably change the port number for the sltt-app so that it is separate from the old compressor install.
Created https://github.com/ubsicap/sltt-app/issues/4 to address the conflicting port
electron-builder
environment variables to setCSC_LINK
andCSC_KEY_PASSWORD
(according to their documentation https://www.electron.build/code-signingyarn build:win
in the sltt-electron directory to produce v1.0.3 of the sltt-electron app (which I posted here https://signlanguaget-nfl9249.slack.com/files/U04QB2E53HB/F06TWQT4VV0/sltt-electron-1.0.3-setup.exe):