search

ubsuny / 23-Homework4G1

This is the main repository for 23-Homework4G1 and is based on GitHub actions for linting and unit testing.
https://github.com/ubsuny/23-Homework4G1
Apache License 2.0
1 stars 11 forks source link

Should Linting Automatically Fix Issues in Code? #42

Open WildJimmy opened 1 year ago

WildJimmy commented 1 year ago

Someone in my group raised this question, but I wanted to ask other groups. Does the linting action have to fix the issues raised by the linter, or should we be doing that manually? I know there are some linters that do both as mentioned in class, but since we're sticking with pylint I'm not sure if we should implement another action that does this

github-actions[bot] commented 1 year ago

Bravo! You've created your first issue

s4il3sh commented 1 year ago

Someone in my group raised this question, but I wanted to ask other groups. Does the linting action have to fix the issues raised by the linter, or should we be doing that manually? I know there are some linters that do both as mentioned in class, but since we're sticking with pylint I'm not sure if we should implement another action that does this

Yea. there is an online linting tool as mentioned by the professor which automatically corrects our code. But linting via GitHub actions only gives us the output as a suggestion and we manually fix it.

reshnashrestha commented 1 year ago

For git hub actions, we are supposed to work on linting suggestions manually.

AhmedCode99 commented 1 year ago

nope

Mosaddeq107 commented 1 year ago

Someone in my group raised this question, but I wanted to ask other groups. Does the linting action have to fix the issues raised by the linter, or should we be doing that manually? I know there are some linters that do both as mentioned in class, but since we're sticking with pylint I'm not sure if we should implement another action that does this

Yea. there is an online linting tool as mentioned by the professor which automatically corrects our code. But linting via GitHub actions only gives us the output as a suggestion and we manually fix it.

Right