search

ubsuny / 23-Homework4G1

This is the main repository for 23-Homework4G1 and is based on GitHub actions for linting and unit testing.
https://github.com/ubsuny/23-Homework4G1
Apache License 2.0
1 stars 11 forks source link

Effect of making changes #72

Open Mosaddeq107 opened 1 year ago

Mosaddeq107 commented 1 year ago

Hi, @reshnashrestha If I make minor changes in a Python file, will it affect the running action workflow?

Mosaddeq107 commented 1 year ago

@LinxuanHu Do you have?

Mosaddeq107 commented 1 year ago

More precisely, if I add some docstrings to our Python file.

Hi, @reshnashrestha If I make minor changes in a Python file, will it affect the running action workflow?

reshnashrestha commented 1 year ago

@Mosaddeq107 We did linting and pytest on the unit test file and as per suggestions, I made changes now our unit test has 10/10 ratings for pylint and it satisfies pystest, so we don't need changes on that file. However, on the algorithm file it works fine any other changes will be trivial.... we can discuss this tomorrow on campus before class.