search

ubsuny / 23-Homework4G3

Apache License 2.0
0 stars 11 forks source link

Choosing alternative Hw #44

Closed sharmistharanit closed 11 months ago

sharmistharanit commented 11 months ago

Can we use another previous hw since it is not working correctly? @laserlab @yasmensarhan27 @AhmedCode99

AhmedCode99 commented 11 months ago

it is working fine

AhmedCode99 commented 11 months ago

just checked again. Working fine. what is your error?

sharmistharanit commented 11 months ago

Check the updated code by Dr. Tim. @AhmedCode99 For unit testing, I have to call the function from the algorithm part. There is no such function exists in the providing code. So, professor has updated the code.

sharmistharanit commented 11 months ago

Your code is perfectly fine. However, I have to write code for unit test.

reshnashrestha commented 11 months ago

@sharmistharanit Can you share the code you copied? I think you have to modify the code as per the task you can the code to run.

laserlab commented 11 months ago

in the original code everything is hardcoded. As I mentioned in class that is not very useful and now it bites you for the unit tests.

sharmistharanit commented 11 months ago

The code worked for unit test. @laserlab can you check once.

laserlab commented 11 months ago

Can you link what I should check?

sharmistharanit commented 11 months ago

https://github.com/sharmistharanit/23-Homework4G3/blob/fad9c1d3f66c9b0b53f8523236ac03db558ceca4/projectile_unit_test.py

laserlab commented 11 months ago

The code looks ok for me but I didn’t run it. Again. Maybe an easier example would be more educational. Does it work in the GitHub action?

yasmensarhan27 commented 11 months ago

Yeah it worked on GitHub actions and we have an output file for the purest

On Tue, Oct 17, 2023 at 3:33 PM laserlab @.***> wrote:

The code looks ok for me but I didn’t run it. Again. Maybe an easier example would be more educational. Does it work in the GitHub action?

— Reply to this email directly, view it on GitHub https://github.com/ubsuny/23-Homework4G3/issues/44#issuecomment-1767043843, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJFAAC3WIK2ECJDNST24GRLX73MP3AVCNFSM6AAAAAA6C5IEYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRXGA2DGOBUGM . You are receiving this because you were mentioned.Message ID: @.***>