search

ubsuny / 23-Homework4G4

MIT License
0 stars 10 forks source link

Confused about the pylinting #32

Closed pratibha77118 closed 8 months ago

pratibha77118 commented 8 months ago

Hi @poojashresthacode @WildJimmy, Are we supposed to do pylint using git hub action too? I am confused whether we have to resolve the issues we get from pylint or write git hub action only?

WildJimmy commented 8 months ago

I think we're supposed to write the action for linting, then resolve the issues raised by the action on the original solution. So you then end up with a 'cleaner' version of the original homework solution

pratibha77118 commented 8 months ago

Thanks I will do the linting first.

poojashresthacode commented 8 months ago

I think we have to do linting for the unit test.

pratibha77118 commented 8 months ago

I did the pylinting for the algorithm with module too. So is it okay to make just the issues about what I get or make a pull request on it.