search

ubsuny / 23-Homework4G4

MIT License
0 stars 10 forks source link

Create linting_periodic_test.yml #38

Open s4il3sh opened 1 year ago

s4il3sh commented 1 year ago

this yaml file will check the quality of your code.

pratibha77118 commented 1 year ago

@s4il3sh I did the pylinting but am not able to resolve the issue like the one you got while linting our code. The error is same: The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-python@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/ The test status is failed because of this issue. Any idea on resolving this issue??

laserlab commented 1 year ago

Any specific reason to go to v2 of those workflows, instead of using v4 as in my example code? Not sure if it matters for that problem though.

laserlab commented 1 year ago

If I look at your run https://github.com/ubsuny/23-Homework4G4/actions/runs/6529064754 it only was complaining about the node issue in a warning. Output of plying looked fine to me

s4il3sh commented 1 year ago

@pratibha77118 the code is fixed by changing v2 to v4 as mentioned by prof. @laserlab. You may accept the merge request. And it works now without errors.