search

ubsuny / 23-Homework5G2

MIT License
0 stars 10 forks source link

slicing (data length) #84

Open yasmensarhan27 opened 10 months ago

yasmensarhan27 commented 10 months ago

Hello @Pranjal-Srivastava-2023 @pratibha77118

I think you have missed a part during writing the code

to adjust the length of data to some value of 2^n

you should have slice the data to get rid of one element to have len(values)= 2^7 right??

yasmensarhan27 commented 10 months ago

I've done it in a branch on my repository https://github.com/yasmensarhan27/23-Homework5G2/tree/yasmensarhan27-slicing_fixing you can check it. it worked properly as well Do you think I've to merge it??? @pratibha77118 @Pranjal-Srivastava-2023

@laserlab what do you think, prof. Tim ?? Our data is of length 129. so we have to slice it using [1: ] to have len(data)= 2^7 or it will not be a big issue so no need to merge the new one??

laserlab commented 10 months ago

you can also use padding to make it 256 long. But always use a multiple of 2