search

ubsuny / 23-Homework6G3

This is the main repository for 23-Homework6G3 involving calculus.
https://github.com/ubsuny/23-Homework6G3
Apache License 2.0
0 stars 7 forks source link

Merging lead to failed github action workflows which should be managed #55

Closed reshnashrestha closed 8 months ago

reshnashrestha commented 8 months ago

Hi pranjal I accepted you merge request. But the calculus.py file you created has multiple differences to the one i made. I worked on my task and had completed my task today and it took time to manage all from pylint to pytest to unit tests and all. So after merging yours, neither pytest not pylint are satisfied so now I will keep your ipynb file but I will revert to the one file I created and that calculus.py does not fall under any task so we can have our individual as per ours task in our forked repo. hope you are okay with it. Screenshot (61)

reshnashrestha commented 8 months ago

@Pranjal-Srivastava-2023

reshnashrestha commented 8 months ago

image

Pranjal-Srivastava-2023 commented 8 months ago

@reshnashrestha It is okay, let us keep the old file. But for my task, I modified calculus.py. I have sent you the modified version with the name calculus_main.py and the outputs are based on this.

reshnashrestha commented 8 months ago

Okay I will check.

reshnashrestha commented 8 months ago

resolved.