ubsuny / CP1-24-HW1

Homework template for CP1 in 2024
1 stars 17 forks source link

Map classical inputs to a quantum problem and optimize it for a quantum computer #27

Open laserlab opened 2 months ago

laserlab commented 2 months ago

Check out: https://learning.quantum.ibm.com/tutorial/chsh-inequality

and implement Steps 1 and 2 for our project

if you copy code make sure to respect potential copyright and licenses

zbpetersbuf commented 2 months ago

here let me try and do this

laserlab commented 2 months ago

can you link your pr to this issue?

zbpetersbuf commented 2 months ago

How do I do that again? Is it done here or on my fork?

zbpetersbuf commented 2 months ago

Also, for my comments of the code, should I define and describe each thing, meaning when I say 'this is how you add a Hadamard gate, should I also describe or define what a Hadamard gate is?

zbpetersbuf commented 2 months ago

29 'linked'

laserlab commented 2 months ago

Also, for my comments of the code, should I define and describe each thing, meaning when I say 'this is how you add a Hadamard gate, should I also describe or define what a Hadamard gate is?

Not at this point others can work on this too.

laserlab commented 2 months ago

Just let me know @zbpetersbuf when you’re done so I can merge

zbpetersbuf commented 2 months ago

So like I didn't think I was done but I was? I am so confused, Is there anything left for me to do with this task now or do I find something else to do now?

laserlab commented 2 months ago

This was kind of the first step in this task, but it deserved it own PR. So we keep this issue open and you can look into Step 2 (optimize for a quantum computer and open a new PR for that so you get 2 PRs for your homework. Technically everything could have been done in one PR but to get more homework points it makes sense to split it into two. I hope that makes sense now.

zbpetersbuf commented 2 months ago

what was a pr again? and in the grading it shows zero points for them

laserlab commented 2 months ago

PR is a pull request. Grading is done after the homework is due.

zbpetersbuf commented 2 months ago

aw pr accepted is zero points nvm

laserlab commented 2 months ago

@zbpetersbuf no worries you are on the right track!