ubsuny / CP1-24-HW2

Homework2 template for CP1-24
1 stars 15 forks source link

Documentation edits #66

Open Priyanka-43 opened 1 month ago

Priyanka-43 commented 1 month ago

Added documentation for code.

kylemasc917 commented 1 month ago

Please squash these commits as @laserlab has previously mentioned. I will add a reviewer for this and once both are finalized this can be merged.

kylemasc917 commented 1 month ago

@abruns123 I have added you as reviewer for this if you can get to it at your nearest convenience thank you.

abruns123 commented 1 month ago

image

Here's an image of the preview per your reference

Priyanka-43 commented 1 month ago

Hi, I have made the required changes. Please have a look.

kylemasc917 commented 1 month ago

@abruns123 If you could review this now after the edits, please, and @Priyanka-43 If you could also squash these commits as well please and thank you.

Priyanka-43 commented 1 month ago

@kylemasc917 I have tried a lot. I watch some videos as well. but i unable to do that. I am really sorry for that.

kylemasc917 commented 1 month ago

@laserlab Do these need to be squashed for them to be merged or for this project can I merge them anyway?

laserlab commented 1 month ago

@laserlab Do these need to be squashed for them to be merged or for this project can I merge them anyway?

You can squash them @kylemasc917 But be aware @Priyanka-43 That this will cost you homework points.

kylemasc917 commented 1 month ago

@Priyanka-43 If you are ok with that I can go ahead and merge the pull request but only upon your explicit approval.

Priyanka-43 commented 1 month ago

Yes please. Thankyou so much for your help.

kylemasc917 commented 1 month ago

@Priyanka-43 @abruns123 There is an outstanding conflict that is preventing this from being merged.