search

ubsuny / CP1-24-HW2

Homework2 template for CP1-24
1 stars 15 forks source link

Open PRs #69

Closed avgagliardo closed 1 month ago

avgagliardo commented 1 month ago

I see that there a still a lot of open PRs waiting review (16 at the moment) so I think we need to change strategies if we are going to hit the deadline.

Maybe after a certain point today/tomorrow we should just start reassigning the PR reviews to anyone who is available or else a lot of people will not be getting points.

I don't mind doing extra PR reviews, but I wont be able to review my own-- currently I have one and there will probably be 3 more coming tonight.

Anyone else want to join in and volunteer for PR review overflow duty?

ojha-aditya commented 1 month ago

I can pitch in for a few, but maybe we should ask @laserlab first if we could bypass the review process like this?

avgagliardo commented 1 month ago

Yeah agreed, that's why maybe we should wait until tomorrow minimally.

Priyanka-43 commented 1 month ago

I have the same query. My 3 PR are still open.

avgagliardo commented 1 month ago

I have the same query. My 3 PR are still open.

I can dedicate some time tomorrow afternoon to get through a bunch of these.

In the meantime, if you are waiting on a PR review you could also try to @ the person in the PR comments to give them a polite reminder.

kylemasc917 commented 1 month ago

I can start dropping reminders in pull requests if they don't get reviewed by the time I get to campus tomorrow I can start adding you two to the open ones.

Priyanka-43 commented 1 month ago

I have the same query. My 3 PR are still open.

I can dedicate some time tomorrow afternoon to get through a bunch of these.

In the meantime, if you are waiting on a PR review you could also try to @ the person in the PR comments to give them a polite reminder.

I have done the same.

kylemasc917 commented 1 month ago

You have outstanding issues in the pull requests made by @laserlab that need to b fixed before they can be reviewed and merged.

Priyanka-43 commented 1 month ago

Hi, I tried to do that.

laserlab commented 1 month ago

If you’re PR is waiting for review send messages with mentions to the reviewer tonight. Also if there is no response for ones open and reviewer was reminded feel free to change reviewer.

iglesias-cardinale commented 1 month ago

I can also do some reviewing of PRs tomorrow before the deadline if necessary.

kylemasc917 commented 1 month ago

I will add your name to my list thank you very much.

abruns123 commented 1 month ago

I can also review more pull requests.

kylemasc917 commented 1 month ago

Excellent I shall add you as well.

avgagliardo commented 1 month ago

I'll leave this thread open until tomorrow in case anybody else wants to volunteer, then I'll close it.

kylemasc917 commented 1 month ago

I have added all of you that volunteered to do extra reviews to the pull requests that need them. I tried to spread them out evenly. Feel free to do so when you get the chance.