search

ubsuny / CP1-24-HW3

Homework 3 template for CP1-24
1 stars 16 forks source link

How to review a PR #13

Open laserlab opened 1 week ago

laserlab commented 1 week ago

To successfully finish a review a PR you have to do the following:

  1. Check the checklist in the Homework description
  2. Check title, description, (target/destination) branch and commits
  3. Review each file carefully and click “viewed” of every file you reviewed. The linting results from the automated check can help you with this task.
  4. In the review tab you have to choose one of the following options and add a comment about the PR
    • Approve: Submit feedback and approve merging the changes proposed in the pull request.
    • Request changes: Submit feedback that must be addressed before the pull request can be merged.
  5. Submit the review

For more information on each step read: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request

dnxjay commented 1 week ago

Do we get points for a review that we request changes or do we have to keep going until its approved?

haiderabbas007 commented 6 days ago

If the lint score is 0 but the code and unit tests are running fine, what should be done in such a case?