search

ubsuny / CP1-24-HW3

Homework 3 template for CP1-24
1 stars 16 forks source link

IRV function with unit tests #14

Closed zbpetersbuf closed 1 month ago

zbpetersbuf commented 1 month ago

have a working function with unit checks, however, it is not yet complete since I only included 1 function given in the assignment when I was supposed to use 2 so it is not yet complete. So do not accept this pull request

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

laserlab commented 1 month ago

Assigned @avgagliardo as reviewer. @zbpetersbuf Please let the reviewer know when it is ready for review.

avgagliardo commented 1 month ago

@zbpetersbuf I'm still watching this, but ping me whenever you want me to review it.

laserlab commented 1 month ago

@zbpetersbuf I'm still watching this, but ping me whenever you want me to review it.

@avgagliardo I thin you should review this now since there was no reply.

laserlab commented 1 month ago

PR has an appropriate name and description.

Module lacks necessary docstrings and code comments.

Several files are not well-formed and either lack a proper filename or have issues with the structure/syntax of the code which will prevent it from executing.

The main module seems to execute, but upon manual testing its functionality it fails.

Additionally, the unit-tests are not complete and they do not execute.

I noted the use of lambda functions and the filter() built-in method, which fulfils the homework's specified programming requirements.

For now I will review this as requesting changes, but I can review it again whenever you get time to update it.

Agreed to all. Nothing to add.

zbpetersbuf commented 1 month ago

having issue with saving files cause of a file named IRVfunk.cpython-312.pyc

avgagliardo commented 1 month ago

having issue with saving files cause of a file named IRVfunk.cpython-312.pyc

delete your pycache directory and pull the .gitignore file from the main repo. You may also have to remove those files from being tracked by git, but I think deleting the compiled .pyc files should be enough to solve that particular issue.

zbpetersbuf commented 1 month ago

having issue with saving files cause of a file named IRVfunk.cpython-312.pyc

delete your pycache directory and pull the .gitignore file from the main repo. You may also have to remove those files from being tracked by git, but I think deleting the compiled .pyc files should be enough to solve that particular issue.

thank you for your answer even at this time I appreciate it

zbpetersbuf commented 1 month ago

I think I resolved the changes requested, but if resolving this requires you to do something like accepting my resolves, don't worry about it its late and I don't expect you to do anything