ubsuny / CP1-24-HW3

Homework 3 template for CP1-24
1 stars 16 forks source link

Isn't merging supposed to be blocked? #18

Closed HeshamElsaman closed 1 week ago

HeshamElsaman commented 1 week ago

Isn't merging being blocked till a review takes place this time?

avgagliardo commented 1 week ago

PR's are supposed to be reviewed before a merge. Not sure what the current permissions for the repo are, but if you can merge I would wait until its properly reviewed otherwise someone might miss out on their PR review points.

laserlab commented 1 week ago

Since I’m the maintainer, it’s not that critical but I put back the same ruleset as in the last homework to have that nice red cannot be merged