search

ubsuny / CP1-24-HW3

Homework 3 template for CP1-24
1 stars 16 forks source link

magnetic field of straight line #27

Closed Priyanka-43 closed 1 month ago

Priyanka-43 commented 1 month ago

In this pull request, I have written documentation part of Magnetic Field of wire and try to elaborate with figure as well.

laserlab commented 1 month ago

This documentation file is complete and well written, all equations are legible latex code. Just a few things need to be addressed.

  1. A description of the materials in the pull request needs to be added.
  2. Are the files for the rest of the homework assignment going to be added in a later pull request? -If so, this can be merged once 1. is addressed. -If not, then those files need to be added as soon as possible.

Agreed. ~@kylemasc917 do you want to also review #46 since there is actual code to review? You don’t have to you’ve already done your duty.~

Priyanka-43 commented 1 month ago

@kylemasc917 Hi, Can you please explain little more for your first comment?

And i have made another Pull request for Code.

kylemasc917 commented 1 month ago

Yeah. The Pull request currently has no description provided (the box at the top is blank). In order for this to be merged according to the homework assignment there needs to be a brief description of the contents of the pull request. You can do this by pressing the three dots in the top right of the first box, pressing edit, and adding a description.

laserlab commented 1 month ago

@kylemasc917 Hi, Can you please explain little more for your first comment?

And i have made another Pull request for Code.

Can you link that PR here? There is no other authored by you in the open PR list in this repository

laserlab commented 1 month ago

@Priyanka-43 As per homework description only one PR is to be made. If you want to code count to your homework you have to add the files to this PR here NOW.

Priyanka-43 commented 1 month ago

Ok, I have added my code part to the same pull request.

laserlab commented 1 month ago

Ok, I have added my code part to the same pull request.

@kylemasc917 Would you mind reviewing the code as well?

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Priyanka-43 commented 1 month ago

@kylemasc917 Hello, I wanted to ask about the unit test part. Shall we used pytest an unit test libraries to make sure it will be running or if it is already giving the results so I am done with the unit test part?

kylemasc917 commented 1 month ago

Yes you need to write a unit test module even if the code is running properly as a check like constructing a proof for a problem even if you got the expected value.

Priyanka-43 commented 1 month ago
image

I have written this code. If you please have a look.

kylemasc917 commented 1 month ago

A few things. This looks like it is written in Jupyter notebook which will not work as was mentioned in class on Friday I believe, and you never import the function from your code module into the unit test, so it isn't testing anything. If I'm misreading this code feel free to tell me so but those are my observations.

Priyanka-43 commented 1 month ago

Hello Professor, I have tried to resolve. I have done all import in starting of the code. i have deleted the parameters(variables) which I have used more than one. Try to take one module math.pi or np.pi.