search

ubsuny / CP1-24-HW3

Homework 3 template for CP1-24
1 stars 16 forks source link

Linting required in HW? #33

Open ojha-aditya opened 1 month ago

ojha-aditya commented 1 month ago

@laserlab do we need to compulsorily implement listing for this HW?

laserlab commented 1 month ago

no, but the reviewer might point out shortcomings to your code which includes the same errors that the linter points out

laserlab commented 1 month ago

see also #35

ojha-aditya commented 1 month ago

Understood. Thank you

ojha-aditya commented 1 month ago

So as reviewer we also go through the linting score and get that fixed before approving?

laserlab commented 1 month ago

The linter will help you to review, but there can be more issues that the linter doesn’t catch

ojha-aditya commented 1 month ago

And what is a good enough linting score to merge the PR?

ojha-aditya commented 1 month ago

Also, can we use code formatters like Black for linting the code automatically? For future HWs I mean.

laserlab commented 1 month ago

Also, can we use code formatters like Black for linting the code automatically? For future HWs I mean.

You can use autoformatters.

ojha-aditya commented 1 month ago

Thank you for the clarification, closing this as well.

haiderabbas007 commented 1 month ago

Also, can we use code formatters like Black for linting the code automatically? For future HWs I mean.

Does this mean our code will get corrected on the go and won't have linting issues when we do a PR or when we do local linting? If so, why are such autoformatters not applied to codespaces/IDEs etc. by default to get rid of linting issues altogether?