search

ubsuny / CP1-24-HW3

Homework 3 template for CP1-24
1 stars 16 forks source link

Reviewers: Check the linting results #35

Open laserlab opened 1 month ago

laserlab commented 1 month ago

There is an automated test running for each PR that lints the code. It will help the reviewers to make a thorough review of the submitted algorithm. As a reviewer you MUST point out at least the problematic issues that the linter also found. Check the details of the test under the pylint section. It lists all linting errors and also a score.

Be aware though that linters do not catch everything. In particular if the code runs and produces the correct result.

haiderabbas007 commented 1 month ago

Do we just need to point it out or do we also need to request changes in such instances when reviewing a PR?