search

ubsuny / CP1-24-HW3

Homework 3 template for CP1-24
1 stars 16 forks source link

Implemented PoyntingVector module #38

Closed ojha-aditya closed 1 month ago

ojha-aditya commented 1 month ago

Hereby I have written the functions to implement the Poynting vector for plane polarized electromagnetic waves. The PR contains the following in the PoyntingVectorModule folder:

  1. Module PoyntingVector.py which implements the functions to generate the electromagnetic wave expressions and Poynting vector expressions and calculate the numerical value for the same.
  2. TestPoyntingVector.py which is the unit test module for PoyntingVector.py
  3. Markdown file contains the Physics of Poynting vector calculations done using the above module.
  4. There is a separate Jupyter notebook that can be used the test the functions individually.
review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

laserlab commented 1 month ago

@Tolani4 Please review asap

ojha-aditya commented 1 month ago

Also, should I just remove the Jupyter notebook from this PR as it is not longer needed? I had kept it just for trial run purposes.

laserlab commented 1 month ago

Also, should I just remove the Jupyter notebook from this PR as it is not longer needed? I had kept it just for trial run purposes.

sure remove it if it is not needed

ojha-aditya commented 1 month ago

Done. Removed the Jupyter notebook, will soon commit. Also, is there a way to reflect the lint test results in our codespaces so it could be compared and fixed line by line?

ojha-aditya commented 1 month ago

@laserlab I have comitted all changes requested and got the linting score up as well. Removed the main function and loop, the remaining linting suggestions are a tradeoff it seems, resolving them causes another issue to pop up.

laserlab commented 1 month ago

merging with wrong formatted docstrings and linting issues