search

ubsuny / CP1-24-HW3

Homework 3 template for CP1-24
1 stars 16 forks source link

ReviewNB for reviewing task #39

Open ojha-aditya opened 1 month ago

ojha-aditya commented 1 month ago

Do we have to use the ReviewNB bot that was discussed in last class when we review a pull request?

laserlab commented 1 month ago

only if it is a Jupyter notebook. Since the actual function should be in a module it shouldn’t be necessary often

ojha-aditya commented 1 month ago

Got it. And the bot also checks for linting?

laserlab commented 1 month ago

no, only *.py files are checked

ojha-aditya commented 1 month ago

No I meant if it is a Jupyter notebook, then does the bot check for linting too? Understood it won't be in our case.

laserlab commented 1 month ago

no, linting is only checked for *.py files

ojha-aditya commented 1 month ago

Got it. Closing this issue as well. Thank you very much.

haiderabbas007 commented 1 month ago

So there's no mechanism for linting or checking jupyter notebook files?