ubsuny / CP1-24-HW3

Homework 3 template for CP1-24
1 stars 16 forks source link

New pull requests will not be reviewed anymore #47

Closed laserlab closed 1 month ago

laserlab commented 1 month ago

For everyone that has an assigned review please review asap so there is more time for the authors of the PR to fix.

jkblc commented 1 month ago

I'm sorry, I was working today and didn't realize that the pull request was due before class, but we didn't have class today. I wrote the method and unit tests and it is in my repository just didn't open my pull request. I guess it's pointless by now.

dnxjay commented 1 month ago

Im confused about this, last i knew the pull request were due today but there was a specific time for it so i feel like that unfair to the people who havent submitted it yet due to there not being a specific time for it

laserlab commented 1 month ago

The time is mentioned in the milestone. I didn't see a PR from @jkblc. If you both @dnxjay want you can review each others PR.

jkblc commented 1 month ago

Will do. I''l check my pylint and open a pull request @dnxjay

dnxjay commented 1 month ago

@jkblc ill keep a look of for it. If you can review mine when you get a chance that would be nice thank you