Closed iglesias-cardinale closed 1 month ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@iglesias-cardinale ~While you are too late for your PR to be fixed after review~, I assigned you PR #46 so you can get your reviewer points in. And I assigned @HeshamElsaman your PR to review it.
- I'm actually not sure about linting, even for myself, but the code is well-functioning.
The main linting complain that you could have picked up too for the review are the missing docstrings.
not merging due to unfixed issues
Added a module to find electrostatic potential from a set charge distribution. This could be expanded to include continuous charge distributions. Module includes lambda functions and iterators (np.enumerate).
Added brief documentation on the theory of electrostatic potential. This should be added to.
Added unit test module to test