ubsuny / CP1-24-HW3

Homework 3 template for CP1-24
1 stars 16 forks source link

Electrostatic Potential #48

Closed iglesias-cardinale closed 1 month ago

iglesias-cardinale commented 1 month ago

Added a module to find electrostatic potential from a set charge distribution. This could be expanded to include continuous charge distributions. Module includes lambda functions and iterators (np.enumerate).

Added brief documentation on the theory of electrostatic potential. This should be added to.

Added unit test module to test

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

laserlab commented 1 month ago

@iglesias-cardinale ~While you are too late for your PR to be fixed after review~, I assigned you PR #46 so you can get your reviewer points in. And I assigned @HeshamElsaman your PR to review it.

laserlab commented 1 month ago
  • I'm actually not sure about linting, even for myself, but the code is well-functioning.

The main linting complain that you could have picked up too for the review are the missing docstrings.

laserlab commented 1 month ago

not merging due to unfixed issues