search

ubsuny / CP1-24-HW3

Homework 3 template for CP1-24
1 stars 16 forks source link

PR closing #51

Closed dnxjay closed 1 month ago

dnxjay commented 1 month ago

Why does PR need to be done before "class" if today's a holiday and a break away from school. If we have tomorrow and Wednesday which is a working class day to do the reviews then what's the point of having a deadline that not until midnight?

avgagliardo commented 1 month ago

Why does PR need to be done before "class" if today's a holiday and a break away from school. If we have tomorrow and Wednesday which is a working class day to do the reviews then what's the point of having a deadline that not until midnight?

I think its because writing software this way (as a group using source control) is such a push/pull process that you need some time for both people on each end to do their parts. Writing code takes time, reviewing code takes time, making the necessary changes to that code.... takes time, etc.

The sooner we all start the codedance the faster we can start rolling out useful systems.

dnxjay commented 1 month ago

That's understandable but we have kept it to the end of the day all semester so far seems kind of unfair to change that on a day we arent at school

avgagliardo commented 1 month ago

I cant speak to the policy itself, I just know what not having headroom to work does to a team (from learning it the hard way lol)

kylemasc917 commented 1 month ago

Also changing deadlines is pretty commonplace in a number of environments so I wouldn't be surprised given the nature of previous assignments that isn't also one of the goals of that particular change.