search

ubsuny / CP1-24-HW7

Homework template for Homework 7
1 stars 14 forks source link

Trapezoidal Method implemented using built-in Python functions #16

Closed ojha-aditya closed 1 day ago

ojha-aditya commented 2 days ago

Implemented the Trapezoidal method according to #2

Linting

Contents

Labels and Milestone

Reviewer

ojha-aditya commented 2 days ago

Does it not check for pylint by default @zbpetersbuf? Both build tests show Pytest somehow.

zbpetersbuf commented 2 days ago

@laserlab ya the build seems to have issue I was going to bring it up with Dr Thomay, since pylint seems to be missing for everyone and is instead replaced with another pytests

ojha-aditya commented 2 days ago

Yeah, I guess it is fixed now in PR #19, will update the branch before anyone take up the review itself.

ojha-aditya commented 2 days ago

Yes it now checks for lint, I guess now it will be easier for the reviewer to check the pylint status.

ojha-aditya commented 2 days ago

I discussed with @laserlab and will remove the functionality for plotting from the calculus module as that is not required.

@zbpetersbuf just putting here so it can be put on hold before merging. Will push the necessary commits tonight.

zbpetersbuf commented 2 days ago

So just let me know when it can be merged, ill be sure to check everything before bed

zbpetersbuf commented 2 days ago

@ojha-aditya You still need a reviewer, ill be your second one

ojha-aditya commented 2 days ago

So just let me know when it can be merged, ill be sure to check everything before bed

It is ready to be reviewed and merged now, I removed the plotting functionality and improved the docstrings in the last commit.

ojha-aditya commented 2 days ago

@ojha-aditya You still need a reviewer, ill be your second one

I guess we could assign randomly if no one takes up the review by themselves?

zbpetersbuf commented 1 day ago

Ya I mean that's why I felt like your review doesn't have to be your partner, since sometimes it could just work better if it was anyone