ubunchuu-truong-us / ubunchuu-truong-us.github.io

▶️ Open-source ubunchuu-truong-us linux documentation. Built with 💚 and built for easy contribution 👨🏻‍💻.
https://ubunchuu-truong-us.github.io/
10 stars 0 forks source link

Enable local vscode dev container and install node, starship prompt through Dockerfile #9

Closed thangbuiq closed 9 months ago

thangbuiq commented 9 months ago

@lelouvincx Should we build and push image to GCR or should we keep Dockerfile inside the .devcontainer folder and build on user's machine?

lelouvincx commented 9 months ago

@lelouvincx Should we build and push image to GHCR or should we keep Dockerfile inside the .devcontainer folder and build on user's machine?

I think both. I prefer pushing the image to GHCR. So that contributor can save time by just pulling from ghcr. Also provide Dockerfile, to make him understand what's inside the devcontainer.