Add the title and copyright info

ubuntu-flutter-community / settings

:penguin: :orange_heart: :blue_heart: An Ubuntu Desktop system settings app made with Flutter.

GNU General Public License v3.0

273 stars 48 forks source link

Closed YoussefLasheen closed 1 year ago

YoussefLasheen commented 1 year ago

Fix for #385

I solved this by saving the image's title to the file name and view it under the image.

Change the saving directory to /Documents/ImageOfTheDay/providername/image.jpeg
Created two new classes to make it easier to add more providers
Format the Nasa copyright info to be like bing's
Used HD image from the NASA's api if available

I wanted to embed the copyright info to the image actual metadata but couldn't do it.

YoussefLasheen commented 1 year ago

Did it really just fail because of some trailing commas? :thinking:

Jupi007 commented 1 year ago

Yes, there is a formatting analysing, to ensure code good practices and consistency :)

Which code editor are you using? Because, with VS Code, there are Dart + Flutter extensions which provide automatic formatting and linting.

You can also run: dart fix --apply. This will apply the recommended fix to the project.

YoussefLasheen commented 1 year ago

Should I add a fix for this and other unrelated commits(they're related to the wallpaper page) to this pr or should I open individual ones? @Jupi007

Jupi007 commented 1 year ago

For the design change, please do it in this PR, as the caption as been introduced here.

For the other problem, I will open an issue. If you want, I can assign you on it 🙂

YoussefLasheen commented 1 year ago

Can you check now please?