ubuntu-flutter-community / settings

:penguin: :orange_heart: :blue_heart: An Ubuntu Desktop system settings app made with Flutter.
GNU General Public License v3.0
273 stars 48 forks source link

Wallpaper page: add dark mode support #406

Closed Jupi007 closed 1 year ago

Jupi007 commented 1 year ago

In the current state, the wallpaper is defined for both dark/light theme. GS supports to have different wallpaper depending on the theme, and it would be nice to add this feature here.

CC @YoussefLasheen if you want to grab it :)

shan-shaji commented 1 year ago

@Jupi007 can i take a look at this? I would like to get a little more details and what should be the behaviour that i should achieve.

Jupi007 commented 1 year ago

@shan-shaji ofc you can 🙂

shan-shaji commented 1 year ago

ok thank you @Jupi007

shan-shaji commented 1 year ago

@Jupi007 can i please get a bit more context about the feature?

Feichtmeier commented 1 year ago

basically when you set the wallpaper from the chosen file you need to check what the current theme is and change the gsettings key corresponding to this

shan-shaji commented 1 year ago

@Feichtmeier , i am not that much familiar with gsettings. Really sorry.. do we have any docs?

Feichtmeier commented 1 year ago

Sadly not many docs but you can check what WallpaperModel does and at some point it sets the wallpaper, I think I remember you only need to make a case for the dark wallpaper there

Jupi007 commented 1 year ago

Currently, the wallpaper is set twice: once for light theme once for the dark one.

shan-shaji commented 1 year ago

Got it

shan-shaji commented 1 year ago

@Jupi007v @Feichtmeier but i think the current behaviour supports different wallpaper depending on the theme.

shan-shaji commented 1 year ago

ezgif com-gif-maker (1)

Feichtmeier commented 1 year ago

Nice 👍🙂

Jupi007 commented 1 year ago

Closing, as this feature has been added in #321