search

ubuntu-flutter-community / settings

:penguin: :orange_heart: :blue_heart: An Ubuntu Desktop system settings app made with Flutter.
GNU General Public License v3.0
273 stars 48 forks source link

Set the preview image fit and aspect ratio to preview the wallpaper accuratly #408

Closed YoussefLasheen closed 1 year ago

YoussefLasheen commented 1 year ago

Before (sometimes): Screenshot from 2022-11-26 17-20-10

After: Screenshot from 2022-11-26 17-19-56

Next would be to get the screen's actual aspect ratio but currently it is not supported by google and can only be done by adding window_size manually

Feichtmeier commented 1 year ago

Nice!

The aspect ratio should be gettable via the display service

Jupi007 commented 1 year ago

The aspect ratio should be gettable via the display service

Indeed, so maybe directly update this PR with the correct aspect ratio @YoussefLasheen

Feichtmeier commented 1 year ago

The service should be injected into the model from the view Then you should move all the logic into the model please :) Thanks for working on this

Jupi007 commented 1 year ago

Oh, sorry @Feichtmeier I have forgotten to request your review 😥

Feichtmeier commented 1 year ago

Np we can fix it later