search

ubuntu-mate / mate-dock-applet

application dock for the MATE panel
GNU General Public License v3.0
125 stars 34 forks source link

Icons of wine applications aren't displayed #152

Closed CreamyCookie closed 6 years ago

CreamyCookie commented 6 years ago

The icons of wine applications aren't rendered. Instead the standard wine icon is shown. There also a cog icon, that cannot be clicked:

wine screenshot

The desktop file (created by PlayOnLinux) does show an icon. (It's an image file without an extension.)

robint99 commented 6 years ago

Which distro and applet version are you using? I don't have many games that I can run under PlayOnLinux, but I tried Pharaoh and Cleopatra and that at least did show the correct icon.

pharoah

This was on Ubuntu Mate 18.04 with V0.86 of the applet.

CreamyCookie commented 6 years ago

I'm also using Ubuntu Mate 18.04. My applet version was V0.85, but I've now manually installed from master (which looks a lot better with the high res icons).

Sadly, the issue seems to be still there. I've tried with the Battle.net launcher and it just displays a set of cogs, while the Ubuntu Mate alt-tab-switcher displays the correct icon:

screenshot

Interestingly, when starting a Wine application it displays the right icon but it vanishes after a while (leaving the cogs): screenshot starting

robint99 commented 6 years ago

I've just committed a fix for this. Wine apps now show the Wine icon defined by the icon theme e.g.

Ambient Mate: screenshot at 2018-07-17 08-15-32

Adapta: screenshot at 2018-07-17 08-13-26

As for the invisible windows issues, there seems to be a long standing issue with PlayOnLinux and Freetype (e.g. see here. Basically, because fonts can't be rendered you end up with windows only a few pixels in height and width and these are difficult to see. I ran into exactly this problem when installing Pharoah and when trying to install BattleNet. Hopefully the PlayOnLinux devs will sort this out soon...

I'll close this issue as the icons are now being displayed properly.

CreamyCookie commented 6 years ago

@robint99 Thanks, I've just tried it.

Wouldn't it also be possible to show the right icon like the Mate Alt-Tab switcher does, as shown here:

screenshot

This is the old screenshot (hence the cog, which is the Battle net launcher). The icon in the alt-tab switcher on the right is the correct one.

robint99 commented 6 years ago

It may be that with the new code the Battle Net icon will be displayed correctly. Unfortunately, because of the PlayOnLinux font issue I mentioned above, I haven't been to install it and do any testing...

If you want to try it yourself I've written a Python script to install the latest development version of the applet do this for you, and you can find it here in one of my other repositories.

Cheers.

CreamyCookie commented 6 years ago

Oh, sorry I wasn't clear. I had compiled from master and it's not showing the battle net one, just the default wine one. (which of course is better / more clear then the generic cog)

robint99 commented 6 years ago

After several attempts I was able to get the Battle Net installer to run, and the icon was indeed wrong. I've updated the code again and now the installer does have the correct icon.

screenshot at 2018-07-19 08-36-36

The installer errors out but so I can't test Battle Net itself, but the changes I've made should mean that Battle Net and any other Wine app that sets an icon for itself should show that icon in the dock.

I'll reopen this issue until you have a chance to test if for yourself ...

Cheers

CreamyCookie commented 6 years ago

Thank you, that works perfectly: :+1:

screenshot at 2018-07-19 11-06-21