Open johne8 opened 9 months ago
Attention: 7 lines
in your changes are missing coverage. Please review.
Comparison is base (
8b04ff2
) 83.23% compared to head (941b339
) 83.10%.
Files | Patch % | Lines |
---|---|---|
nss/src/cache/mod.rs | 74.07% | 5 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@johne8: thanks for looking at this and help at figuring out your issue with podman!
I don’t really like that we hardcode the ownership integer value of nobody, which can vary depending on the distribution and user config.
Secondly, this check is to ensure an integrity of the database and poking a hole there doesn’t seem like the right solution. I think looking at the user namespace mapping might help there to ensure that in the parent namespace, the uid/gid still match the expecations, wdyt?
hmm, I'm not too familiar with namespaces. The best thing I can think of currently is reading the values of: /proc/sys/kernel/overflowuid and /proc/sys/kernel/overflowgid, then check if the uid and gid owner matches that.
Have you checked out my latest commit? It seems to work fine :)
Also in Ubuntu 22.04 LTS, it seems like UID/GID above 2147483647 (SignedInt) causes issues in gnome.
So needed to add some workaround for this also by reducing the UID of the users that have a UID calculated above that value.
Workaround for issue #399 allow podman to run with --userns=keep-id