Some parts of App Center do not scale text correctly with "Large Text" mode enabled

ubuntu / app-center

App Store for Ubuntu made with Flutter 🧡 💙

GNU General Public License v3.0

662 stars 116 forks source link

Some parts of App Center do not scale text correctly with "Large Text" mode enabled #1403

Open shytzedaka opened 1 year ago

shytzedaka commented 1 year ago

When using the accessibility mode "Large Text" as presented here: or using the terminal command to get the same effect: gsettings set org.gnome.desktop.interface text-scaling-factor 1.25

Text does not appear to be extending or scaling in some areas of the App Center as can be seen here:

it appears the issue only occurs at the sidebar of the app center and not the rest of the program. Note: I am Using a 1920x1080 Display with regular 100% scale and the App Center is fully maximized

d-loose commented 1 year ago

Thanks for the screenshots! We definitely need to improve the spacing in some places to accommodate larger fonts. A few more screenshots (with ratings backend running):

Normal Font	Large Font

@anaserejio: something to look at when you got time :)

anorld-droid commented 1 year ago

@d-loose I have improved the spacings. Screenshot from 2023-10-06 11-01-21

Should I send a PR, you check it out?

d-loose commented 1 year ago

@d-loose I have improved the spacings.

Thanks - looks great! I'm wondering if there's enough space for the ratings though. Can you check what it looks with the ratings enabled?

RATINGS_SERVICE_URL=ratings.ubuntu.com flutter run

d-loose commented 1 year ago

What is the expected outcome for this, should we increase it's width? https://user-images.githubusercontent.com/113362648/270333836-c626f3e7-0a5d-4bf0-b74a-cf223311ba09.png

I don't know yet, we'll need to patiently wait for @anasereijo, who works on the design for the app center.

anorld-droid commented 1 year ago

@d-loose I have improved the spacings.

Thanks - looks great! I'm wondering if there's enough space for the ratings though. Can you check what it looks with the ratings enabled?
RATINGS_SERVICE_URL=ratings.ubuntu.com flutter run

Yeah, not so good. We may have to increase the height of the card to accommodate the summary;it has a maxlines of 2 OR make its maxlines to 1.

What do you think, @d-loose?

anasereijo commented 1 year ago

Hi @shytzedaka, thank you for filling the issue. We are planning on doing an accessibility assessment on the app, but in the meantime, feel free to file any issues or propose improvements. :)

@anorld-droid thanks for doing this 🙌 one question: are you changing the height of the cards when Large text is enabled or for both situations (enabled and disabled)?

anorld-droid commented 1 year ago

Hi @shytzedaka, thank you for filling the issue. We are planning on doing an accessibility assessment on the app, but in the meantime, feel free to file any issues or propose improvements. :)

@anorld-droid thanks for doing this 🙌 one question: are you changing the height of the cards when Large text is enabled or for both situations (enabled and disabled)?

Both, but I will add when Large text is enabled; I had not thought of that.

shytzedaka commented 1 year ago

hey! it seems that this bug so far persists in released Ubuntu 23.10.1 (Clean install of the latest public ISO) I'm not sure if this is still being fixed or not but i thought it would be worth pointing that out since we're out of the beta phase.

olekzonder commented 11 months ago

Text does not scale with other languages like Russian, where the word meaning Manage ("Управление") or About ("Об App Center") are too big to fit and get cut off by dots.

I don't think it looks right. I'm using the Snap Store from the Edge channel.

shytzedaka commented 5 months ago

Is there an update on this?

d-loose commented 5 months ago

We'll have some time for polishing and bug fixing this cycle and also plan to do some refactoring :). While a lot of accessibility issues need to be fixed in the Flutter embedder, this issue is simply caused by an inflexible implementation of the layout and can/should be fixed here.

shytzedaka commented 5 months ago

Thank you for your hard work :)

frankhuurman commented 2 months ago

Just want to chime in that even without Large Text mode or any sort of scaling enabled it can't spell "Manage" completely on a 1080p screen even though it looks like there's plenty of space. Just upgraded to 24.04.1 from 22.04.4, not sure if it's something on my end or happens for others as well.

d-loose commented 2 months ago

Just want to chime in that even without Large Text mode or any sort of scaling enabled it can't spell "Manage" completely on a 1080p screen even though it looks like there's plenty of space. Just upgraded to 24.04.1 from 22.04.4, not sure if it's something on my end or happens for others as well.

That was a different issue, see #1782 (fixed in latest/edge, will be rolled out to stable branches soon)

frankhuurman commented 2 months ago

@d-loose ah perfect, thanks for the quick reply Dennis :)