search

ubuntu / app-center

App Store for Ubuntu made with Flutter 🧡 💙
GNU General Public License v3.0
669 stars 117 forks source link

Taiwanese Chinese(zh_TW) localization not working #1857

Closed brlin-tw closed 1 week ago

brlin-tw commented 3 weeks ago

I have the zh_TW locale set in the system settings:

$ locale
LANG=zh_TW.UTF-8
LANGUAGE=zh_TW:zh_CN:en
LC_CTYPE="zh_TW.UTF-8"
LC_NUMERIC=zh_TW.UTF-8
LC_TIME=zh_TW.UTF-8
LC_COLLATE="zh_TW.UTF-8"
LC_MONETARY=zh_TW.UTF-8
LC_MESSAGES="zh_TW.UTF-8"
LC_PAPER=zh_TW.UTF-8
LC_NAME=zh_TW.UTF-8
LC_ADDRESS=zh_TW.UTF-8
LC_TELEPHONE=zh_TW.UTF-8
LC_MEASUREMENT=zh_TW.UTF-8
LC_IDENTIFICATION=zh_TW.UTF-8
LC_ALL=

but the UI still shows zh_CN translated strings:

Screenshot

Version: revision b2772108 (which should have zh_TW translation available since revision eea52798)

d-loose commented 3 weeks ago

Thanks for your report! Currently there are no translations in app_zh_TW.arb, so I think app_zh.arb is used as a fallback. There might be something wrong with the weblate setup - the available components there are zh_Hans and zh_Hant. I'll have a closer look at this next week!

brlin-tw commented 3 weeks ago

@d-loose

Thanks for your attention! IMHO the zh_Hans and zh_Hant shouldn't be used and should be replaced with region-specific zh_XX locale codes.

taijuin commented 3 weeks ago

Maybe just the same way as other projects. 123

d-loose commented 1 week ago

@d-loose

Thanks for your attention! IMHO the zh_Hans and zh_Hant shouldn't be used and should be replaced with region-specific zh_XX locale codes.

Thanks, I've commented on our current setup in #1864. I think this is in line with the setup used on launchpad (see here and here. In principle Flutter supports a more advanced locale setup, but I don't think this is supported by weblate (and we currently don't have the time to look into that, unfortunately).

A new build should land in the latest/edge and 2/edge channels of the snap-store snap in a few hours. Please feel free to re-open this issue in case there are still some problems :)

taijuin commented 1 week ago

001

ok~!

Thanks

brlin-tw commented 5 days ago

@d-loose

A new build should land in the latest/edge and 2/edge channels of the snap-store snap in a few hours. Please feel free to re-open this issue in case there are still some problems :)

Apologies for the ignorance, I can verify the build in the 2/edge channel works, thanks for the help!