Closed Feichtmeier closed 1 year ago
Do you mean like this? or perhaps with a label
If possible, I think it would be best no to have a button on one page and a popup/dropdown on the other. Can we use a popup/dropdown on the PackagePage too?
Yeah maybe. Or just a normal button that forwards you to the deb page. So you can keep the navigation intact
Or just a normal button that forwards you to the deb page. So you can keep the navigation intact
Toggle buttons / segmented buttons
Woops, it's not really closed unless you guys say so, but the functionality is there. But I started with an outlined button because this is much easier with the navigator because it is now
banner > snap + deb > click > snap page first > switch to deb button > deb page
then
appbanner < snap page < back button
Hey @Feichtmeier thanks for sharing the screenshot. I wonder if it's not possible to do the switch button as we proposed?
It is possible but it does not make so super much sense since you navigate from page to page. It's not really a state of one page but a navigation from one page to the other. If you really insist on the toggle I can do it but in my humble opinion it does not make too much sense from the feel of navigation
@Feichtmeier Can't you use Navigator.pushReplacement
to replace the current page?
It is possible but it does not make so super much sense since you navigate from page to page. It's not really a state of one page but a navigation from one page to the other. If you really insist on the toggle I can do it but in my humble opinion it does not make too much sense from the feel of navigation
Good point @Feichtmeier. I think @anasereijo wants to give the illusion that the content is loaded dynamically (even if it's an entirely different page) so the container (with the name, icon,...) stays the same. Or at least what was what I understood π
It is possible but it does not make so super much sense since you navigate from page to page. It's not really a state of one page but a navigation from one page to the other. If you really insist on the toggle I can do it but in my humble opinion it does not make too much sense from the feel of navigation
Good point @Feichtmeier. I think @anasereijo wants to give the illusion that the content is loaded dynamically (even if it's an entirely different page) so the container (with the name, icon,...) stays the same. Or at least what was what I understood π
yes @madsrh that's exactly it! As we show the apps as one banner (on search results and explore page), it makes it look like it's one 'page' dedicated to the same app and then the user can select to see either the snap or deb.
@Feichtmeier is this already available to try it out?
Yes, should be usable after
sudo snap refresh snap-store
I would like to add that package formats are no secret in Linux land and we shpuld not try to hide them or abstract them away
@anasereijo
Another reason to not give the illusion that both apps are the same ( which they are not by any means ), is that you can also install the snap and not the deb, or both, or none, or the deb but not the snap. Little video demonstrating this (where I also found a little layout issue with the button :P )
There should probably also be a "switch to Snap" button if the user is currently on the deb version of a package. :D
Also, as things are right now, the apps page doesn't tell the user what package format it is currently using, albeit in an implicit way (switching to debian implies that it is a Snap). I feel like this should be made more obvious, maybe by having an "App Format" section next to the version number?
Yeah def a good idea to show the format on the AppPage - maybe in the AppBar?
GIMP (snap) GIMP (debian)
or with icons?
Anyways, those buttons are also unfinished I just wanted to point out that I think that the illusion of "one app" is a bad idea and we need the navigation for "muscle memory" and visualisation that you switch the app format
Hi @Feichtmeier, first of all, happy new year!
I am sorry, but I don't understand why we can't have the 'switch' button as proposed. Might be easier/quicker to schedule a quick call to discuss this.
@madsrh @anasereijo
Now in main to test:
also increased default window size and reduced padding to avoid overflow of the buttons in the "default" size of the window
This looks very busy. Too many buttons IMHO.
I think I would still have preferred a dropdown here (not the latest/stable dropdown though π) Shouldn't the Debian label be white?
I know this is just a test, but switching between the two packageformats has a short blank page (shimmer). Is that fixable somehow (caching the other page)?
Hey! I am having issues with the update β I don't see the changes. I will try again Monday.
In the meantime, I have some questions/feedback from what I can see on the screenshots:
We prosed moving reviews down below, next to the information about the package. So all the content that changes when we switch between Snap and Deb will be below those buttons. We also proposed moving the publisher as well, but we then agreed that it can stay at the top down below the app name.
I don't see a reason why we display the 'update' button when there are no updates available. Is there a reason why?
@madsrh is right - the Dedian label should be in white as well
this is more visual related, but isn't the font for the app name way too big and disproportional with the rest of the content? Maybe if we reduce it a bit, it will help to tidy up the layout.
'Uninstall' button should be after the channel dropdown. The same when we have an 'update' button. I have ordered items when I did this mockup.
thank you and have a nice weekend!
Hopefully I can test this on Monday (fingers crossed!)
This looks very busy. Too many buttons IMHO.
I think I would still have preferred a dropdown here (not the latest/stable dropdown though π) Shouldn't the Debian label be white?
I know this is just a test, but switching between the two packageformats has a short blank page (shimmer). Is that fixable somehow (caching the other page)?
I agree. The more of I use this the more I'm almost sure we should return to the tab approach of snap/deb
But let's keep this approach for now maybe we find something that looks good and is useable for Ubuntu users
On the other points, let's keep this focused on the part that let's you switch between the app format. I'm already getting confused by all the notifications xD I will work on the app infos in a different issue / pull request
I can remove the update button if there is no update and then we get a bit more space, but as soon as there is an update we still get the crowded row
I agree. The more of I use this the more I'm almost sure we should return to the tab approach of snap/deb
But let's keep this approach for now maybe we find something that looks good and is useable for Ubuntu users
On the other points, let's keep this focused on the part that let's you switch between the app format. I'm already getting confused by all the notifications xD I will work on the app infos in a different issue / pull request
I can remove the update button if there is no update and then we get a bit more space, but as soon as there is an update we still get the crowded row
@Feichtmeier perhaps it would be more "easy on the eyes" if the snap/deb toggle buttons had a dedicated line, like in Anas mockup (I can't find the link atm π ). Do you know what I mean? And ofc this would take up more height - it's just a thought
yes I try this! This super long line is horrible
Even if this looks somehow "ok"
This looks really not ok
Any other idea than the (snap|deb) button?
This looks really not ok
Indeed that looks π© Could you try centering it below the website link?
This looks really not ok
Indeed that looks hankey Could you try centering it below the website link?
Yeah I agree, this looks much better. Though by positioning those buttons on a new line, we run into this issue again https://github.com/ubuntu-flutter-community/software/issues/688
This looks really not ok
Indeed that looks hankey Could you try centering it below the website link?
this is good - any idea for the sm0l window?
eventually we need an exception for these kind of windows anyways I mean, this is a really rare case and I dont know why you would want to do this. We could prevent this by increasing the min height of the window to for example this size
any idea for the sm0l window?
Well, I took the liberty of removing the "Installed date", because this information may be available in the "Additional information" section/widget (if we decide to go with that idea) AND as you said this is a really rare use case. If this isn't enough space, I would, as already suggested, resize the icon and the title.
Resizing is good and also move the Infos to their own section on the right, right?
...Infos to their own section on the right, right?
π€ I'm unsure about moving ALL the info. Wouldn't you want some information available without scrolling like version, filesize, ???
If there's room I would leave these three and we can revisit when the "additional info" section is done.
depends where we place this. we could place it above the media. currently working on this - looks good - I am optimistic
Increasing the min window height feels more like placing a bandaid of the issue than actually fixing it head on. It's also worth keeping in mind that a large portion of users still use low resolution displays:
By making the minimum height 870, we basically alienate all these users. I don't think that changing the size of the title and icon would be enough here. IMO the best solution would be to either place the additional information on the right, or make it scrollable.
yes, it was a band-aid fix just for now, as I said in the PR, no need to diverge this discussion even more ;)
currently working on the app page makeover, please do not panic, everyone relax and drink some beer. Thank you.
@whiskeyPeak Just for reference: telemetry in Ubuntu https://ubuntu.com/desktop/statistics (all the 800x600 is proberly VM's)
... please do not panic, everyone relax and drink some beer. Thank you.
Still a bit too early for beer π€£ but I'm completely relaxed βΊοΈ
Nice @Feichtmeier ! Much improved π I think you should move the publisher back below the title, because it is sometimes very long (there's a comment somewhere from Ana)
but then the grid is always uneven :) Need to pull some other infos out of the toilet then :flushed: :hankey:
Edit: btw, ALL infos shown here can be super varying in length, so this is not really an argument. I push this now and you can test it. The main goal was to have the (snap|deb) button without fucking up the whole page, right?
Yes, please push
There's a lot of spacing, so perhaps we should make it a bit tighter? But then again, this is an unusual huge window π
@madsrh still did not figure out how to keep scaling but move the elements a bit more to the center, but here is the publisher name for wide and narrow windows
Let's wait for ana on monday and see if we can go with this (snap|deb) button now and then we can talk about all of this somewhere else
Fixed by several PRs
Even if I do not like this idea semantically, I see no other room on the pages other than the dropdown for SnapPage
For PackagePage a simple button "Switch to Snap" would be enough