ubuntu / archive_yaru.dart

Ubuntu Yaru Flutter Theme
https://ubuntu.github.io/yaru.dart/
Mozilla Public License 2.0
335 stars 40 forks source link

White dividers with Flutter 3.7.0 #251

Closed jpnurmi closed 1 year ago

jpnurmi commented 1 year ago

M3 Divider uses ColorScheme.outlineVariant on the beta channel:

@override Color? get color => Theme.of(context).colorScheme.outlineVariant;

https://github.com/flutter/flutter/blob/686fe913dc963954b99e62048569cb9ac8e551c8/packages/flutter/lib/src/material/divider.dart#L343

Flutter 3.7.0-1.4.pre • channel beta • https://github.com/flutter/flutter.git
Framework • revision 686fe913dc (9 days ago) • 2023-01-10 16:14:01 -0800
Engine • revision ac5c83dd5f
Tools • Dart 2.19.0 (build 2.19.0-444.4.beta) • DevTools 2.20.0
code sample ```dart import 'package:flutter/material.dart'; import 'package:yaru/yaru.dart'; void main() { runApp( MaterialApp( home: Column( children: [ Expanded( child: Theme( data: yaruLight, child: const Scaffold(body: Center(child: VerticalDivider())), ), ), Expanded( child: Theme( data: yaruDark, child: const Scaffold(body: Center(child: VerticalDivider())), ), ), ], ), ), ); } ```

image

image

Feichtmeier commented 1 year ago

Ewww :( But it looks fixable as you directly provide the solution.

((( How are switches, buttons and ✅ looking?))))

jpnurmi commented 1 year ago

This is related to https://github.com/ubuntu/yaru.dart/issues/252 because ColorScheme.fromSwatch() offers no way to pass the outline colors.

jpnurmi commented 1 year ago

Also visible in the yaru.dart example: image

jpnurmi commented 1 year ago

Fixed by https://github.com/ubuntu/yaru.dart/pull/259 - I forgot to add a reference.

jpnurmi commented 1 year ago

I also didn't notice you had self-assigned this. Sorry if I stepped on your toes... :)

Feichtmeier commented 1 year ago

lol! feel free to step on my toes 💅 👣 😄 so many things to fix