ubuntu / archive_yaru.dart

Ubuntu Yaru Flutter Theme
https://ubuntu.github.io/yaru.dart/
Mozilla Public License 2.0
334 stars 40 forks source link

use handy in the example #371

Closed Feichtmeier closed 1 year ago

Feichtmeier commented 1 year ago

@jpnurmi

For having a better visual impression onto how things affect our desktop apps, do you see any problem in having yaru widgets and handy windy inside the example as a dep?

really helped me a bit with getting to understand how textfields look in action here grafik

jpnurmi commented 1 year ago

The dependency would not be a problem if yaru and yaru_xxx packages were in the same monorepo and managed by Melos. But it will become a problem if they are in separate repos and if you ever want to do any sort of incompatible change because you won't be able to change both dependencies at the same time.

Feichtmeier commented 1 year ago

Would this change anything at yaru.dart support for android/ios/macos/windows and web?

jpnurmi commented 1 year ago

As far as I know, it's only possible to publish one GitHub Pages per repo so you wouldn't be able to have separate GitHub Pages examples for yaru, yaru_widgets, yaru_icons, and whatever would be in the monorepo.

Feichtmeier commented 1 year ago

As far as I know, it's only possible to publish one GitHub Pages per repo so you wouldn't be able to have separate GitHub Pages examples for yaru, yaru_widgets, yaru_icons, and whatever would be in the monorepo.

hm well, then this a no go :) I guess I can live with the retro titlebar and bottom corners for now then :+1:

jpnurmi commented 1 year ago

I think handy_window would be fine, though. :)

Feichtmeier commented 1 year ago

@jpnurmi

nice that we can use handy window, will do soon for the example

I found this to be working for yaru widgets in the example pubspec Is this maybe a manageable risk? :) it says to take the yaru from path for the example no matter what yaru widgets uses : D

    path: ../
  yaru_widgets: ^2.6.0

dev_dependencies:
  flutter_lints: ^2.0.1
  flutter_test:
    sdk: flutter

flutter:
  uses-material-design: true

dependency_overrides:
  yaru:
    path: ../