Issue: incorrect file specified in the documentation and other issues

jcoffi-ghlabs commented 3 weeks ago

Is there an existing issue for this?

[X] I have searched the existing issues and found none that matched mine

Describe the issue

The documentation refers to /etc/logins.def but the file is /etc/login.defs on a brand new install of 24.04 desktop. Also, it says to configure the registered app like the photo: But we don't know what to put for the reply URL.

Where does the issue happens

[ ] I can reproduce the issue in the graphical display manager
[ ] I can reproduce the issue on a terminal with "login"

Steps to reproduce it

Read the documentation and try to follow the steps.

System information and logs

No response

Relevant information

No response

Double check your logs

[X] I have redacted any sensitive information from the logs

jibel commented 3 weeks ago

Thanks for your report.

I fixed the position of the 's' in login.defs and we will have a look at the second issue.

jibel commented 1 week ago

Regarding your second question about the redirect url, we are using the OAuth 2.0 device code flow and a redirect URI is not needed. You can read more about redirect URI in Microsoft documentation.

However, you have a good point, we'll update the screenshot to not show any redirect URI.

jcoffi-ghlabs commented 1 week ago

The picture shows it's there and the instructions imply you should match the picture. It should probably be updated.

From: Jean-Baptiste Lallement @.> Sent: Sunday, September 1, 2024 11:52 PM To: ubuntu/authd @.> Cc: Justin Coffi - Contractor @.>; Author @.> Subject: Re: [ubuntu/authd] Issue: incorrect file specified in the documentation and other issues (Issue #477)

CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

Regarding your second question about the redirect url, we are using the OAuth 2.0 device code flowhttps://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-device-code and a redirect URI is not needed. You can read more about redirect URI in Microsoft documentationhttps://learn.microsoft.com/en-us/entra/identity-platform/reply-url#should-i-add-a-redirect-uri-to-an-app-registration.

However, you have a good point, we'll update the screenshot to not show any redirect URI.

- Reply to this email directly, view it on GitHubhttps://github.com/ubuntu/authd/issues/477#issuecomment-2323946916, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BKR7HLJZAUNVIAYVQVPQNPTZUQDJ3AVCNFSM6AAAAABM2V4GP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRTHE2DMOJRGY. You are receiving this because you authored the thread.Message ID: @.**@.>>

jibel commented 1 week ago

The picture has been updated to not show any redirect URI.

ubuntu / authd