ubuntu / authd

Authentication daemon for external Brokers
GNU Lesser General Public License v3.0
58 stars 8 forks source link

Rework dbusbroker dbus calls to format errors #518

Closed denisonbarbosa closed 1 week ago

denisonbarbosa commented 1 week ago

We now have a wrapper around the dbus calls to be able to intercept the errors and format the messages in a way that is helpful to end user. This helps avoiding error messages that are too technical, such as "the object X was not provided by any .service files" which is returned when the broker is not available on DBus.

UDENG-4094

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.75%. Comparing base (924b003) to head (4b312ca). Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
internal/brokers/dbusbroker.go 92.85% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #518 +/- ## ========================================== - Coverage 84.84% 84.75% -0.10% ========================================== Files 79 79 Lines 6942 6938 -4 Branches 75 75 ========================================== - Hits 5890 5880 -10 - Misses 736 739 +3 - Partials 316 319 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.