search

ubuntu / gnome-sdk

GNOME SDK/Platform snap
22 stars 24 forks source link

Update gjs to version `1.76.2` #151

Closed soumyaDghosh closed 1 year ago

soumyaDghosh commented 1 year ago

Fixes #150

jbicha commented 1 year ago

1.75.1 is not a stable release (it is a pre-stable development snapshot). Maybe you're thinking of 1.76.1?

soumyaDghosh commented 1 year ago

1.75.1 is not a stable release (it is a pre-stable development snapshot). Maybe you're thinking of 1.76.1?

I am trying to find that detail. Can you kindly help me? The main point of mine here is it needs to be updated.

soumyaDghosh commented 1 year ago

https://gitlab.gnome.org/GNOME/gjs/-/commit/1abd669ae0f805a83c50738857291ae50d32f6eb

As much this suggests, should I update gjs to 1.76.1 then?

jbicha commented 1 year ago

It might not be written down anywhere, but I know that gjs 1.75.1 is not a stable series. The part after the 1 (the 75) needs to be an even number to be considered a stable release for the gjs project. Some projects handle version numbers that way and some don't. It is confusing.

I don't know whether gjs 1.76.1 is appropriate or not, but I know that 1.75.1 is not. But gjs 1.76.1 is probably ok since we have glib 2.76.3 which was released around the same time.

sergio-costas commented 1 year ago

At this moment we are keeping the version of GJS to 1.72.x. @kenvandine is who should approve a change like this.

sergio-costas commented 1 year ago

Anyway, you can also compile your own GJS version and include it inside your snap.

kenvandine commented 1 year ago

@3v1n0 suggested it's safe to update GJS, so let's give that a try. We should go with 1.76.2 which fixed some significant memory leaks. Can you please update that?

soumyaDghosh commented 1 year ago

@3v1n0 suggested it's safe to update GJS, so let's give that a try. We should go with 1.76.2 which fixed some significant memory leaks. Can you please update that?

The problem I am getting with gjs 1.76+ is that it's showing that have_gtk4 unknown variable. 

:: Configuring testNamespace.test using configuration
:: Configuring testPackage.test using configuration
:: Configuring testParamSpec.test using configuration
:: Configuring testPrint.test using configuration
:: Configuring testPromise.test using configuration
:: Configuring testRegress.test using configuration
:: Configuring testSignals.test using configuration
:: Configuring testSystem.test using configuration
:: Configuring testTweener.test using configuration
:: Configuring testCairo.test using configuration
:: Configuring testWarnLib.test using configuration
::
:: ../src/installed-tests/js/meson.build:206:3: ERROR: Unknown variable "have_gtk4".

gtk4 is built before gjs, I guess some build-environment variables needs to be added, to add gtk4.

This is the snap build link

https://launchpad.net/~soumyadghosh/+snap/gnome-42-2204-sdk

sergio-costas commented 1 year ago

Mmm... since it is for some kind of tests, maybe there is a meson option to disable building them...

soumyaDghosh commented 1 year ago

Mmm... since it is for some kind of tests, maybe there is a meson option to disable building them...

https://gitlab.gnome.org/GNOME/gjs/-/blob/1.76.2/installed-tests/js/meson.build?ref_type=tags#L206

If you look into this line, which is the from the 1.76.2 tag.

But, from the current master branch

https://gitlab.gnome.org/GNOME/gjs/-/blob/master/installed-tests/js/meson.build?ref_type=heads#L207

It's not there anymore. Also gtk_tests are already set to false.

I guess we should wait for one more update? or should I build from the master branch?

soumyaDghosh commented 1 year ago

@kenvandine @sergio-costas gjs from master branch with latest tag builds successfully.