search

ubuntu / gnome-sdk

GNOME SDK/Platform snap
22 stars 21 forks source link

deps: add libsigc++3.0 #196

Open jssotomdz opened 6 months ago

jssotomdz commented 6 months ago

content snap builds fine, adding libsigc++3.0-0 since it was required in the sdk and I think it makes sense to bundle it given that the previous version is bundled

jssotomdz commented 6 months ago

@seb128 besides some gnome apps like gnome games that are still based on older versions of gnome there might be other apps requiring the library? Not sure if everything in gnome 46 will remove the dependency with libsigc++2? For some cases we bundle both old and new libraries (libwebgtk, libsoup, gtk itself) because some apps aren't ported to a newer version? Just some thoughts I had when deciding to keep the old one but I also see your point

kenvandine commented 6 months ago

I haven't looked at it closely, but my initial thought is keeping them both would allow more apps to be rebased on core24. But it's not unreasonable to say apps that require that lib has to stay on core22. We will need to continue to support the gnome platform for core22, however we often see snap improvements that follow the base so those apps might miss out on those improvements.

seb128 commented 6 months ago

how much difference does it make on the snap size to not have the gtk3 bindings and corresponding libraries? if upstream follows current versions and a new base makes sense the base libraries should probably not used outdated versions either...