search

ubuntu / gnome-sdk

GNOME SDK/Platform snap
22 stars 24 forks source link

Update libmozjs to 115 #249

Closed sergio-costas closed 3 weeks ago

sergio-costas commented 3 weeks ago

GJS is built with libmozjs-115-dev, but in the dependencies for the SDK itself the old limbozjs-102-dev is used. This PR fixes this.

sergio-costas commented 3 weeks ago

Should we keep both versions? (102 and 115) Or it should be enough with the latest one?

3v1n0 commented 3 weeks ago

Si el target es 2404 creo que sea mejor dejar solo la 115. 102 era solo para 22.04.

3v1n0 commented 3 weeks ago

Ops, sorry... I saw Sergio and I went Spanish :joy:.

Anyways, I think 115 is well enough for apps targetting 24.04. :)

sergio-costas commented 3 weeks ago

I'm fully de acuerdo :-D

3v1n0 commented 3 weeks ago

Oh, the only thing... On the non-sdk snap we should likely keep the old version, as the apps compiled with the old version of SDK won't work otherwise.

sergio-costas commented 3 weeks ago

Mmm... but the non-sdk snap is built from the sdk one, so then we must include it here...

sergio-costas commented 3 weeks ago

I'll prepare a new PR.

seb128 commented 3 weeks ago

I think we should remove 102, we didn't really migrate anything to gnome46 yet since we hit snapd issues trying to do