search

ubuntu / gnome-sdk

GNOME SDK/Platform snap
22 stars 24 forks source link

Remove libsoup2 support #253

Closed sergio-costas closed 1 week ago

sergio-costas commented 2 weeks ago

Three libraries (librest, libgeocode and libgweather) still used libsoup-2, although they already support being compiled with libsoup-3. Since mixing both versions when linking binaries is not possible (and, in fact, an specific check is done at runtime to abort the execution if that case is detected), I think that is time to remove the old one.

This PR entirely removes libsoup-2 library and recompiles those three libraries using libsoup-3.

I will mark it as draft to ensure that a discussion is done before merging it.

seb128 commented 2 weeks ago

I think it makes sense to go forward with the new version in 46.

@jbicha you followed the upstream work and handled most of the Debian/Ubuntu archive changes, does that seem reasonable to you that we default to libsoup3 now for the new sdk?

jbicha commented 1 week ago

Basically the only thing in the GNOME world that still uses libsoup2 is libgdata which is used by gvfs. If libgdata isn't used in this snap, then it's a good thing to stop using libsoup2. Even if libgdata is used, libsoup2 should not be used anywhere else in this snap.

sergio-costas commented 1 week ago

It's even worse: it seems that libgdata is used only in gvfsd-google, nothing else...

sergio-costas commented 1 week ago

There is a draft patch to port it to libsoup3, in fact, but has been frozen for a long time https://gitlab.gnome.org/GNOME/gvfs/-/merge_requests/147#note_1519119

jbicha commented 1 week ago

Is gvfsd-google part of this snap? If it isn't, I don't think there any blockers to landing this change.

sergio-costas commented 1 week ago

No, it isn't.

sergio-costas commented 1 week ago

Merging then.

sergio-costas commented 1 week ago

Ops... sorry, I presumed that your vote was already positive.